Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SOS2 Load order #3364

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Fix SOS2 Load order #3364

merged 1 commit into from
Aug 22, 2024

Conversation

Rhinous
Copy link
Contributor

@Rhinous Rhinous commented Aug 22, 2024

Changes

  • Changed SOS2 from needing CE to load before to needing CE to load after

References

  • Fixes this issue caused by the SOS2 assembly not being loaded by the time CE tries loading the SOS2Compat assembly

Reasoning

  • To fix the above issue

Alternatives

  • N/A

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony - Loaded save with a SOS2 ship and ground defences and all worked

@Rhinous Rhinous requested review from a team as code owners August 22, 2024 02:50
@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10500979457.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Aug 22, 2024
@N7Huntsman N7Huntsman merged commit 2b32507 into CombatExtended-Continued:Development Aug 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N7Huntsman N7Huntsman N7Huntsman approved these changes

Assignees
No one assigned
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rhinous @N7Huntsman